add EIP1559 tx button #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
reviewed
Jun 24, 2021
src/index.html
Outdated
| id="sendEIP1559Button" | ||
| disabled | ||
| hidden | ||
| > |
There was a problem hiding this comment.
nit: Can we fix the indentation here?
<button
class="btn btn-primary btn-lg btn-block mb-3"
id="sendEIP1559Button"
disabled
hidden
>
There was a problem hiding this comment.
Sorry about that, yes!
brad-decker
force-pushed
the
add-eip1559-support
branch
from
b45c896
to
c2f5ebb
Compare
| <button | ||
| class="btn btn-primary btn-lg btn-block mb-3" | ||
| id="sendEIP1559Button" | ||
| disabled |
There was a problem hiding this comment.
If we switch to a network that supports EIP-1559 without connecting to an account new button is enabled state.
There was a problem hiding this comment.
Responded in latest commit :D thanks @NiranjanaBinoy
brad-decker
force-pushed
the
add-eip1559-support
branch
from
161067b
to
be8d9d3
Compare
brad-decker
force-pushed
the
add-eip1559-support
branch
from
be8d9d3
to
ddd3dd6
Compare
|
@ryanml @NiranjanaBinoy @adonesky1 this has been rebased to get latest lint rules updated :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds this button but only makes it visible when the network supports EIP-1559
Screen.Recording.2021-06-24.at.4.26.14.PM.mov